Added Preferences::begin overload to select non-default NVS partition #4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be done without the overload :) Preferences.hbool begin(const char* name, bool readOnly = false, const char* partition_label=NULL);Preferences.cppbool Preferences::begin(const char * name, bool readOnly, const char* partition_label){
if(_started){
return false;
}
_readOnly = readOnly;
esp_err_t err = ESP_OK;
if (partition_label != NULL) {
err = nvs_flash_init_partition(partition_label);
if (err) {
log_e("nvs_flash_init_partition failed: %s", nvs_error(err));
return false;
}
err = nvs_open_from_partition(partition_label, name, readOnly ? NVS_READONLY : NVS_READWRITE, &_handle);
} else {
err = nvs_open(name, readOnly?NVS_READONLY:NVS_READWRITE, &_handle);
}
if(err){
log_e("nvs_open failed: %s", nvs_error(err));
return false;
}
_started = true;
return true;
} |
|
Thanks for getting back to me! I did consider doing this, but I wanted the arguments consistent with esp-idf: The parameter Thoughts? |
|
This is Arduino and not IDF :) Partition name will be rarely used anyway |
|
I have pushed the changes as per your suggestion. :) Referring to my original example, now the partition selection becomes an optional argument to the existing Preference::begin function: |
|
thanks :) |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferences library currently works only with the default NVS partition named "nvs". I added an function overload for Preferences::begin to enable use of a separate NVS partition.
For example, if my NVS partition is named "app_data" and namespace "app", I can do the following:
First time contributing - let me know if I'm doing it wrong. Thanks.